net: STD for dual-stream RHCOS 9/10 node migration network tests#4569
Open
azhivovk wants to merge 1 commit intoRedHatQE:mainfrom
Open
net: STD for dual-stream RHCOS 9/10 node migration network tests#4569azhivovk wants to merge 1 commit intoRedHatQE:mainfrom
azhivovk wants to merge 1 commit intoRedHatQE:mainfrom
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (7)
📝 WalkthroughWalkthroughAdds four new pytest modules (one test each) that declare connectivity-preservation scenarios for live migrations of a server VM between RHCOS 9 and RHCOS 10 worker nodes across L2 bridge, primary, localnet, and user-defined network types. Each module sets Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
azhivovk
changed the title
azhivovk
changed the title
Contributor
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
AI Features
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
openshift-virtualization-qe-bot-3
requested review from
orelmisan and
servolkov
openshift-virtualization-qe-bot-3
requested review from
EdDev,
nirdothan and
yossisegev
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@tests/network/l2_bridge/mixed_nodes/test_primary_network_connectivity_mixed_nodes.py`:
- Around line 19-45: The Polarion marker value is duplicated (CNV-0) in the test
function
test_connectivity_over_primary_network_preserved_during_source_migration (and
across other mixed_nodes test modules), causing ambiguous test attribution;
update the pytest.mark.polarion decorator on this function to a unique
placeholder ID (e.g., CNV-0A) and ensure the other mixed_nodes modules
(functions with the same decorator such as in
test_l2_bridge_connectivity_mixed_nodes.py,
test_localnet_connectivity_mixed_nodes.py, test_udn_connectivity_mixed_nodes.py)
each get distinct placeholders (CNV-0B/C/D) or their final real Polarion IDs so
each test function has a unique polarion marker.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 695c7508-c3b6-4e04-aa6d-4fd9fd030b7e
📒 Files selected for processing (7)
tests/network/l2_bridge/mixed_nodes/__init__.pytests/network/l2_bridge/mixed_nodes/test_l2_bridge_connectivity_mixed_nodes.pytests/network/l2_bridge/mixed_nodes/test_primary_network_connectivity_mixed_nodes.pytests/network/localnet/mixed_nodes/__init__.pytests/network/localnet/mixed_nodes/test_localnet_connectivity_mixed_nodes.pytests/network/user_defined_network/mixed_nodes/__init__.pytests/network/user_defined_network/mixed_nodes/test_udn_connectivity_mixed_nodes.py
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:running
|
D/S test |
Contributor
Author
|
Change: remove client migration scenarios |
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:running
|
D/S test |
Contributor
Author
|
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:running
|
D/S test |
STD for network connectivity tests on clusters with mixed RHCOS 9 and RHCOS 10 worker nodes. Tests cover four network types (Linux bridge, localnet, primary UDN, primary network) verifying connectivity is preserved during live migration of the server VM. Server VM migration is considered the more impactful scenario as it tests connectivity preservation from the endpoint holding the listening socket. Both migration directions are covered within other existing tests. Each network type has its own module with shared setup (NNCP, NAD) in the module-level preconditions. The primary network tests share the module and VM setup with the Linux bridge tests, as both use the same VMs. Signed-off-by: Asia Khromov <azhivovk@redhat.com> Assisted-by: Claude Sonnet 4.6
Contributor
Author
|
Change: Add polarion IDs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
STD for network connectivity tests on clusters with mixed RHCOS 9 and RHCOS 10 worker nodes.
Tests cover four network types (Linux bridge, localnet, primary UDN, primary network) verifying connectivity is preserved during live migration of the server VM.
Server VM migration is considered the more impactful scenario as it tests connectivity preservation from the endpoint holding the listening socket.
Both migration directions are covered within other existing tests.
Each network type has its own module with shared setup (NNCP, NAD) in the module-level preconditions.
The primary network tests share the module and
VM setup with the Linux bridge tests, as both use the same VMs.
jira-ticket: https://redhat.atlassian.net/browse/CNV-81981
Summary by CodeRabbit